Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Bug: Toggle top margin on base page #1128

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Bug: Toggle top margin on base page #1128

wants to merge 1 commit into from

Conversation

decon-harsh
Copy link
Member

In mobile view the top margin of main container in vms/templates/base.html earlier was fixed . When the hamburger icon is clicked and navbar expands the main container then should not have a fixed top margin of 100px. Added onclick function to change margin .
Fixes #1109

Type of Change:

  • Quality Assurance
  • User Interface

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

Mocks

Screenshot from 2020-09-24 13-48-47

Before

Screenshot from 2020-09-09 00-58-10

After

Screenshot from 2020-09-24 13-48-52

How Has This Been Tested?

Manually

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@b58bc98). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1128   +/-   ##
==========================================
  Coverage           ?   87.28%           
==========================================
  Files              ?       85           
  Lines              ?     4057           
  Branches           ?      237           
==========================================
  Hits               ?     3541           
  Misses             ?      446           
  Partials           ?       70

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b58bc98...a183a03. Read the comment docs.

Kajol-Kumari
Kajol-Kumari approved these changes Sep 24, 2020
View reviewed changes
Copy link

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@decon-harsh
Copy link
Member Author

@Kajol-Kumari Hey , I have a doubt regarding OSH event, Where can i DM you. I can't find you on Zulip.
Thanks

@Kajol-Kumari
Copy link

Kajol-Kumari commented Sep 24, 2020 •
edited
Loading

@Kajol-Kumari Hey , I have a doubt regarding OSH event, Where can i DM you. I can't find you on Zulip.
Thanks

Hey @decon-harsh you can ask it in the OSH stream of Zulip as anyone of us would be able to answer you there. And you want to tag me, my username is kajol kumari singh for zulip

sanchibansal340
sanchibansal340 approved these changes Sep 27, 2020
View reviewed changes
Copy link

@sanchibansal340 sanchibansal340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sanchibansal340 sanchibansal340 sanchibansal340 approved these changes

@Kajol-Kumari Kajol-Kumari Kajol-Kumari approved these changes

@gaurivn gaurivn Awaiting requested review from gaurivn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Set Top margin of main container
3 participants
@decon-harsh @Kajol-Kumari @sanchibansal340